On Sat, 20 Oct 2018, Ryo Shimizu wrote:
I think the dts should be fixed rather than #ifdef __arm__I agree that we need to change dts to eliminate 32bit enable method from the dtb for 64bit. However, it is also strange that enable-method code for 32bit ARM remains in the 64bit binary as well.
I don't think the dts should be changed. This lets use share a dtb between 32- and 64-bit kernels. The brcm,bcm2836-smp enable-method is documented as being supported only in 32-bit mode:
https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.txt