On 2018/11/28 12:11, Masanobu SAITOH wrote:
Hi. On 2018/11/28 3:29, Jared D. McNeill wrote:Module Name: src Committed By: jmcneill Date: Tue Nov 27 18:29:17 UTC 2018 Modified Files: src/sys/arch/arm/acpi: acpi_platform.c Log Message: Add support for SPCR 16550 and 16450 interface types To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/arch/arm/acpi/acpi_platform.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.SPCR's interface type is the same as DBG's PortType.
s/DBG/DBG2/
src/sys/external/bsd/acpica/dist/include/actbl1.h defines DBG's port type, so it would be good to use actbl1.h's definitions and remove duplicated definitions in acpi_platform.c. It also seems that ACPI_DBG2_ARM_DCC (0x000f) is not treated in acpi_platform.c See also: https://docs.microsoft.com/en-us/windows-hardware/drivers/serports/serial-port-console-redirection-table http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/acpitools/acpidump/acpi.c.diff?r1=1.33&r2=1.34&f=h
--
-----------------------------------------------
SAITOH Masanobu (msaitoh%execsw.org@localhost
msaitoh%netbsd.org@localhost)