Re: CVS commit: src/sys/kern

[Christoph Badura <bad%bsd.de@localhost>]

On Tue, Jan 08, 2019 at 04:03:14PM +0100, Manuel Bouyer wrote:
> On Tue, Jan 08, 2019 at 03:40:23PM +0100, Christoph Badura wrote:
> > On Mon, Jan 07, 2019 at 03:08:38PM +0100, Manuel Bouyer wrote:
> > > it looks like this broke Xen domU:
> > > http://www-soc.lip6.fr/~bouyer/NetBSD-tests/xen/HEAD/
> > > 
> > > [   1.0800662] boot device: xbd0
> > > [   1.0800662] xenbus: can't get state for device/suspend/event-channel (2)
> > > [   1.0800662] unknown device major 0xffffffffffffffff
> > > [   1.0800662] root device (default xbd0a):
> > > 
> > > and it waits for the user to press enter
> > > do you have an idea ?
> > 
> > Really?  Are you sure that change makes a difference?
> 
> No, but it happended at about the same time.
> But a run with a 2019-01-06 13:20 UTC build installs and completes the tests
> successfully, so I guess something after this commit fixed it.

Are you going to test with kern_subr.c reverted to r1.220?  That would be
interesting.

> > I spent Wednesday/Thursday instrumenting that code and figuring out the
> > same symptom (unknown device major) for dom0.  And the cause there is
> > not changed by Michael's change.
> 
> I'm not sure that the "unknown device major" message is a problem, it
> may have been this way before.

You get that message because rootdev isn't set.  setroot_root() return,
root_device is still NULL and RB_ASKNAME gets set in boothowto.  After
that it should sit at a prompt and wait for someone to enter a root device
name.  The system shouldn't boot automatically.