re: CVS commit: src/sys/compat/netbsd32

[matthew green <mrg%eterna.com.au@localhost>]

"Paul Goyette" writes:
> Module Name:	src
> Committed By:	pgoyette
> Date:		Wed Jan 30 02:00:02 UTC 2019
> 
> Modified Files:
> 	src/sys/compat/netbsd32: netbsd32_compat_80.c
> 
> Log Message:
> Remove #ifdef COMPAT_80
> 
> The file will only be selected if "options COMPAT_80" is defined in
> the config file.  The COMPAT_80 macro is defined only if the option
> is explicitly defined, and not if it is implicitly defined due to
> inclusion of lesser-version COMPATs.

actually, the problem wasn't that it's not defined (it better
be!), but that the opt_foo.h wasn't / isn't included.

removing the #ifdef check is the right answer, but i wanted
to be sure you understood _why_ this was failing before.  it
still may be useful to include the opt_foo.h file -- depends
on if header files may depend on it or not (and i tend to
believe they should include them directly), but this file
itself does not.

thanks.


.mrg.