Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/ufs/ufs
On Mon, Feb 25, 2019 at 05:50:08AM +0000, David Holland wrote:
> Furthermore, this:
>
> > + rawbuf -= dropend;
>
> is entirely wrong (it needs to be "rawbufmax") and without that bound
> on rawbufmax the code is unsafe...
I repaired this bit just now, so it's not an overt hazard any more.
I still don't like this change all that much but whatever, I suppose...
> Here's the fix I got bogged down trying to build and test, which also
> adds a missing upper bound on callerbytes:
that one doesn't set dropend correctly for small buffers, outsmarted
myself while writing it.
--
David A. Holland
dholland%netbsd.org@localhost
Home |
Main Index |
Thread Index |
Old Index