Re: CVS commit: src/sys/dev/pci

[Michael <macallan%netbsd.org@localhost>]

Hello,

On Fri, 22 Mar 2019 17:07:10 +0000
maya%netbsd.org@localhost wrote:

> On Fri, Mar 22, 2019 at 07:41:41AM +0000, Martin Husemann wrote:
> > @@ -1402,6 +1402,9 @@ radeonfb_loadbios(struct radeonfb_softc 
> >  	pci_find_rom(pa, romt, romh, romsz, PCI_ROM_CODE_TYPE_X86, &biosh,
> >  	    &sc->sc_biossz);
> >  
> > +	if (sc->sc_biossz == 0 || sc->sc_bios == NULL)
> > +		return;
> > +
> >  foundit:
> >  	if (sc->sc_biossz > 0) {  
> 		^^^^^^^ Now the else branch isn't possible?

...and we also need to re-enable video DMA and output, so this is
wrong, and I committed a fix earlier anyway.

have fun
Michael