Re: CVS commit: src/sys

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2019/04/24 20:18, SAITOH Masanobu wrote:
> Module Name:	src
> Committed By:	msaitoh
> Date:		Wed Apr 24 11:18:21 UTC 2019
> 
> Modified Files:
> 	src/sys/arch/arm/imx: if_enet.c
> 	src/sys/dev/pci: if_wm.c
> 
> Log Message:
> SIOCS is 'S'et function and the ioctl argument is ifreq.
> SIOCG is 'G'et function and the ioctl armument is ifmediareq.
> Before this change, SIOCG modify sc->sc_flowflags unexpectedly.
> Don't hook SIOCGIFMEDIA becauise this driver uses MII(4) and ether_ioctl has
> the hook(if_ethersubr.c rev. 1.160).

The following line is garbage(copy&paste mistatke):
> real bug because the modification is overriden in ifmedia_ioctl().

>  This driver might require some additional fixes for SIOCSIFMTU and other
> ioctl()s.
> 
> XXX pullup-[78].
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.18 -r1.19 src/sys/arch/arm/imx/if_enet.c
> cvs rdiff -u -r1.633 -r1.634 src/sys/dev/pci/if_wm.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 


-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)