Re: CVS commit: src/external/gpl3/gdb/dist/gdb

[christos%astron.com@localhost (Christos Zoulas)]

In article <20190617063353.57514FBF6%cvs.NetBSD.org@localhost>,
matthew green <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>Module Name:	src
>Committed By:	mrg
>Date:		Mon Jun 17 06:33:53 UTC 2019
>
>Modified Files:
>	src/external/gpl3/gdb/dist/gdb: ppc-nbsd-nat.c sh-nbsd-tdep.c
>
>Log Message:
>fix cross gdb build on sh and ppc:
>- gdb_assert.h has moved into common/gdb_assert.h.
>- force promotion to avoid compile errors
>
>XXX why aren't these files built into the native binary, and
>triggered normal build failures.

They are built into the native binary... There is a
    -I${DIST}/gdb/common \
in the Makefile. Perhaps we should remove it. Also:

# XXX: I should fix these...
CPPFLAGS.i386-nbsd-tdep.c+= -Wno-narrowing
CPPFLAGS.arm-get-next-pcs.c+= -Wno-narrowing
CPPFLAGS.mips-tdep.c+= -Wno-narrowing
CPPFLAGS.sh-nbsd-tdep.c+= -Wno-narrowing
CPPFLAGS.ppc-nbsd-tdep.c+= -Wno-narrowing
CPPFLAGS.alpha-nbsd-tdep.c+= -Wno-narrowing
CPPFLAGS.alpha-tdep.c+= -Wno-narrowing
CPPFLAGS.rs6000-tdep.c+= -Wno-narrowing
CPPFLAGS.hppa-nbsd-tdep.c+= -Wno-narrowing

christos