Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/bin/ps



On 19.06.2019 00:31, matthew green wrote:
> "Kamil Rytarowski" writes:
>> Module Name:	src
>> Committed By:	kamil
>> Date:		Tue Jun 18 02:23:29 UTC 2019
>>
>> Modified Files:
>> 	src/bin/ps: print.c
>>
>> Log Message:
>> Make LSDEAD usage conditional
>>
>> LSDEAD is not used since NetBSD-5.0 and will be gone.
>>
>> The same conditional usage is already in ps.c in the same program.
> 
> please revert this so that it works on netbsd-4 and earlier
> kernels.
> 
> ps(1) is expected to be binary compatible for a very long
> time now.
> 
> 
> .mrg.
> 

It still works on NetBSD-4 kernels (if it doesn't, it's not caused by
this change).

The only difference is that it will print '?' for (LS)DEAD process
(short-lived state).

sysstat ps.c has this change for a long time now.

How about this change:

Index: bin/ps/print.c
===================================================================
RCS file: /cvsroot/src/bin/ps/print.c,v
retrieving revision 1.131
diff -u -r1.131 print.c
--- bin/ps/print.c	18 Jun 2019 02:23:29 -0000	1.131
+++ bin/ps/print.c	19 Jun 2019 00:01:20 -0000
@@ -588,6 +588,8 @@
 	case LSZOMB:
 #ifdef LSDEAD
 	case LSDEAD:
+#else
+	case 6:
 #endif
 		*cp = 'Z';
 		break;

Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index