Re: Stateful commits, "revert previous"

[maya%netbsd.org@localhost]

On Sun, Jun 23, 2019 at 10:23:59AM -0700, John Nemeth wrote:
> On Jun 23,  6:57am, maya%netbsd.org@localhost wrote:
> }
> } > Log Message:
> } > Revert previous
> } > 
> } > There is fallout in gdb that will be investigated before relanding this.
> } > 
> } > 
> } > To generate a diff of this commit:
> } > cvs rdiff -u -r1.363 -r1.364 src/sys/kern/kern_sig.c
> } 
> } Looking at this file on GitHub's history it looks like:
> } 
> } Revert previous
> } 2 days ago
> } 
> } Enhance reliability of ptrace(2) in a debuggee with multiple LWPs
> } 2 days ago
> } 
> } Eliminate PS_NOTIFYSTOP remnants from the kernel 
> } 2 days ago
> } 
> } It's hard to tell whether you reverted both, or just the last one.
> } 
> } It would be nice if, in general, we avoided stateful commit messages
> } like this, and included a snippet of the original commit message.
> } 
> } e.g. Revert previous "Enhance reliability of ptrace(2) in a ..."
> 
>      "revert previous" generally means the immediately preceeding
> commit.  If github can't easily show you what that is, then that
> is its problem.
> 
> }-- End of excerpt from maya%netbsd.org@localhost

One can infer the purpose of commits from their content, too, so maybe
we can do away with commit messages entirely.