Re: CVS commit: src/sys/kern

On Jun 29, 2019, at 2:29 AM, Maxime Villard <max%m00nbsd.net@localhost> wrote:

[...]

Ah because now I should teach people C programming?

No, but you should be helpful and assume that the people working on this

project are not trying to annoy you or ignore you. If would have been

better to explain what the bugs are, instead of sending a "there are

more bugs" message. This saves everyone time. You could have also sent

me a patch and asking if this is right and optionally ask for permission to

commit it. This is typically how people collaborate.

Perhaps the reason you are not forgiving to other peoples' mistakes is because

you make much fewer of them, but that does not give you the right to mistreat others.

Even the simple sentence you typed above has a hostility tone in it, and will make

whoever answers you be on the defensive (or more commonly do nothing to

avoid conflict as most people do).

You don't even understand what happened. What happened is that, one more time,
for the 10^n-th time, Christos demonstrated complete carelessness, to the
point he did not even spend one second of brain time trying to understand the
issues I pointed him to in the very first mail of this thread.

You are making assumptions about someone else's understanding of the

situation. How would you know that they don't understand? I think that the issue

is that your are putting yourself in their position and then judging their behavior

based on how you'd behave in that situation. This results to "your" truth, but not to

"their" truth.

In this case, perhaps I could have spent more time, found the bug and not introduced

a new one. But why would I intentionally make things worse? Wouldn't I have to fix

them again? I tried to fix things to the best of my abilities and time and failed. Should

I be insulted for it?

Let's just remember how it all started. I was not even thinking about touching any

code that day. Someone wanted an explanation about how this function worked

and I went I wrote a comment about it. The rest is all history.

On the contrary,
he tried to dismiss them, make a joke of them, and then proceeded to add even
more bugs than there already were, not paying a single attention to what he
was doing. It's not like it was some kind of highly complicated subsystem to
deal with, either.

I tried to make a joke because you seem to decide to change other people's code

without asking. You don't like debugging code, you remove it; there is no discussion

with the author (and this is not the first time). This is not how people work together.

I also made the joke because I did not see the bug, and removing debugging

lines is usually not helpful to find a bug. Also since you changed the code, you could

have fixed it; why didn't you?

These would seem like entirely acceptable mistakes (part of being human, etc),
if Christos didn't already have a very long history of committing this kind of
absolute nonsense in the kernel. This level of systematic carelessness simply
is not acceptable, and that is why I got really upset. The rest is off-list.

Yes, and I take full responsibility for them and I try to do better. I doubt that I will

ever be perfect. I find and fix other people's bugs or the time but I don't get

upset with them or insult them. In fact I used to be snarky, mentioning in the commit

message the person who introduced the bug as a joke (hi $author), but then I

realized it was not funny and created a toxic environment so I stopped doing it.

If you did not like what I was doing and you believe that I am harming the project

with my careless behavior, you should have (and you probably finally did)

complained to board instead.

christos