Re: CVS commit: src/sys/kern

[Martin Husemann <martin%duskware.de@localhost>]

On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
> On 07.11.2019 14:25, Valery Ushakov wrote:
> > If the sanitizer does complain about other uses, there is little point
> > in fixing one instance and not the others.
> 
> We already agreed with Christos that this is appeasing of GCC. If you
> want to scan the whole kernel (or whole C) file for more occurrences of
> violations - please go for it.

No. The commit needs to be reverted, and then

 a) either the root cause for the unaligned address be fixed or
 b) some other means be found to make the sanitizer shut up

As uwe said: papering over a tiny detail that *never* hits in the real
world but potentialy hiding a real issue is not the way to go.

Martin

P.S.: Independend of this I would still like an official C standard
clarification; in my reading a simple address calculation is not
accessing an object through a pointer (which would be the undefined
behaviour). If the C standard is not clear on this, it needs to be
improved.