Re: CVS commit: src/sys/kern

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 08/12/2019 à 00:51, Kamil Rytarowski a écrit :
> On 08.12.2019 00:35, matthew green wrote:
> > > Module Name:	src
> > > Committed By:	kamil
> > > Date:		Sat Dec  7 19:50:34 UTC 2019
> > >
> > > Modified Files:
> > > 	src/sys/kern: subr_kcov.c
> > >
> > > Log Message:
> > > Revert the in_interrupt() change to use again the x86 specific code
> > >
> > > This is prerequisite for kMSan and upcoming kernel changes.
> > >
> > > Discussed with <maxv>
> >
> > why is this?  what is the problem?

kMSan has special constraints which, in this specific case, come down to: each
function called from a KCOV instrumentation callback must be a static inline
tagged with __nomsan.

This was not the case with the updated in_interrupt(), but also still isn't the
case with the lwp_getspecific() call, which will have to be dropped.