Re: CVS commit: src/sys/arch/zaurus/conf

[Nick Hudson <nick.hudson%gmx.co.uk@localhost>]

On 04/01/2020 16:32, Izumi Tsutsui wrote:
> > > The problem is caused by sys/arch/arm/conf/Makefile.arm.
> > > It defines "COPTS+= -mapcs-frame" in recent rev 1.52
> > >    http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/arm/conf/Makefile.arm#rev1.52
> > > but MI sys/conf/Makefile.kern.inc defines COPTS+=-O2
> > > only if COPTS is empty.
> >
> > I don't see how as sys/arch/zaurus/conf/INSTALL doesn't define DDB.
>
> On zaurus GENERIC also has a size restriction (due to bootloader).

Yes, I understand that. What I don't understand is how my
sys/arch/arm/conf/Makefile.arm change affects the zaurus INSTALL kernel
size because INSTALL specifically disables DDB and my patch is
conditional on DDB


> > > This affects not only zaurus but all arm ports?
> >
> > Maybe this patch is better?
>
> I wonder if it will work as expected if COPTS+="-Os" is
> already specified with options DDB, if -mapcs-frame
> is mandatory for DDB. But if -fno-omit-frame-pointer
> in Makefile.amd64 may have the similar problem,
> it's also okay for arm, IMO.
>
> Maybe it's less probematic to add a new option (COPTS_MD etc.)
> and add it to COPTS after including Makefile.kern.inc,
> i.e. in "(11) Appending make options." in Makefile.arm?

My patch allows COPTS to be overridden as


http://src.illumos.org/source/xref/netbsd-src/sys/conf/Makefile.kern.inc#69

has

69 DEFCOPTS?=	-O2
70 COPTS?=	${DEFCOPTS}

which I believe allows COPTS to be overridden by

makeoptions COPTS="..."

Nick