Re: CVS commit: src/sys/dev/pci

[Jason Thorpe <thorpej%me.com@localhost>]

> On Jan 9, 2020, at 2:54 AM, SAITOH Masanobu <msaitoh%netbsd.org@localhost> wrote:
> 
> Module Name:	src
> Committed By:	msaitoh
> Date:		Thu Jan  9 10:54:16 UTC 2020
> 
> Modified Files:
> 	src/sys/dev/pci: if_stge.c if_stgereg.h
> 
> Log Message:
> Reduce diff against OpenBSD. No functional change.
> 
> - USE CSR_{READ,WRITE}_*() macro.
> - Move some macros from if_stge.c to if_stgereg.h

This diff is incorrect.  The macros that were moved to if_stgereg.h are not related to hardware / register definitions, but are purely software constructs.  Please move them back to if_stge.c.  Doing incorrect things simply to reduce the diff against someone else's copy of the code is not something we should be undertaking.

-- thorpej