Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/arm/include/arm32



> >m68k also needs this? (currently no common <m68k/vmparam.h> though)
> 
> Good catch. Yup, looks like it:
 :
> 
> #define       MIN_PAGE_SHIFT  11                      /* sun2 */
> #define       MAX_PAGE_SHIFT  13                      /* amiga,atari,sun3 */
> #define       MIN_PAGE_SIZE   (1 << MIN_PAGE_SHIFT)
> #define       MAX_PAGE_SIZE   (1 << MAX_PAGE_SHIFT)

sun2 is different MACHINE_ARCH (m68000) from other m68k ports,
so MIN_PAGE_SHIFT should be 12.

> Should I take care of it or can you?

I just wonder which header file these definitions should be in.
Is <m68k/param.h> ok?

PGSHIFT is defined in <machine/param.h> and
PAGE_SHIFT and PAGE_SIZE is in <machine/vmparam.h>,
but there is no common <m68k/vmparam.h>.

---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index