Re: MAX_PAGE_SIZE for m68k (Re: CVS commit: src/sys/arch/arm/include/arm32)

[christos%astron.com@localhost (Christos Zoulas)]

In article <200114002918.M0108172%mirage.ceres.dti.ne.jp@localhost>,
Izumi Tsutsui  <tsutsui%ceres.dti.ne.jp@localhost> wrote:
>christos@ wrote:
>
>> LGTM too.
>
>> >> thorpej@ wrote:
> :
>> >> How about the attached diff? (untested, just for review)
>> > 
>> > This looks good to me.
>
>Now I get the following erro during local tests of
>"build.sh -U -m hp300 release" on NetBSD/i386 9.0_RC1 host:
>
>---
>#    create  compat_util/compat_exec.d
>CC=/s/cvs/src/obj.hp300/tooldir.NetBSD-9.0_RC1-i386/bin/m68k--netbsdelf-gcc
>/s/cvs/src/obj.hp300/tooldir.NetBSD-9.0_RC1-i386/bin/nbmkdep -f
>compat_exec.d.tmp  --   -std=gnu99   -I/s/cvs/src/common/include
>-DDIAGNOSTIC --sysroot=/s/cvs/src/obj.hp300/destdir.hp300
>-I/s/cvs/src/common/include -DDIAGNOSTIC -nostdinc -I.
>-I/s/cvs/src/sys/modules/compat_util -isystem /s/cvs/src/sys -isystem
>/s/cvs/src/sys/arch -isystem /s/cvs/src/sys/../common/include -D_KERNEL
>-D_LKM -D_MODULE -DSYSCTL_INCLUDE_DESCR    
>/s/cvs/src/sys/compat/common/compat_exec.c &&  mv -f compat_exec.d.tmp
>compat_exec.d
>In file included from /s/cvs/src/sys/sys/param.h:149:0,
>                 from /s/cvs/src/sys/compat/common/compat_exec.c:41:
>./m68k/pmap_motorola.h:165:5: error: operator '*' has no left operand
> #if PAGE_SIZE == 8192 /* NBPG / (SG4_LEV1SIZE * sizeof(st_entry_t)) */
>     ^
>nbmkdep: compile failed.
>*** [compat_exec.d] Error code 1
>
>---
>
>I'm not sure why my <m68k/vmparam.h> change causes this error,
>but I also wonder if we should use "PGSHIFT == 13" rather than
>"PAGE_SIZE == 8192" in <m68k/pmap_motorola.h>..

try cc -E?

christos