Re: CVS commit: src/external/cddl/osnet/lib/libdtrace

[Santhosh Raju <fox%netbsd.org@localhost>]

On Mon, Mar 16, 2020 at 8:18 PM Santhosh Raju <fox%netbsd.org@localhost> wrote:
>
> On Mon, Mar 16, 2020 at 8:02 PM Christos Zoulas <christos%astron.com@localhost> wrote:
> >
> > In article <20200317005012.DAF4AFB28%cvs.NetBSD.org@localhost>,
> > Santhosh Raju <source-changes-d%NetBSD.org@localhost> wrote:
> > >-=-=-=-=-=-
> > >
> > >Module Name:   src
> > >Committed By:  fox
> > >Date:          Tue Mar 17 00:50:12 UTC 2020
> > >
> > >Modified Files:
> > >       src/external/cddl/osnet/lib/libdtrace: Makefile
> > >
> > >Log Message:
> > >external/cddl/osnet: Supress -Werror=maybe-uninitialized error in libdtrace.
> > >
> > >It looks like this is a false positive, since the section of code
> > >triggering the error
> > >
> > >external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.c:400:42:
> > >
> > >is only accessed after "err" is initialized.
> > >
> > >Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag.
> >
> > You did not just suppress the error; you suppressed the warning too...
> > There is a difference between -Wno-error=maybe-uninitialized and
> > -Wno-maybe-uninitialized. I think we want the first flavor, otherwise
> > this is a large axe that will hide other warnings in the long run.
> >
>
> Agreed, I shall make the change to be -Wno-error=maybe-uninitialized.
>

https://mail-index.netbsd.org/source-changes/2020/03/17/msg115173.html

Should be fixed in this commit.

--
Santhosh