Re: CVS commit: src/sys/arch/arm/sociox

[Jared McNeill <jmcneill%invisible.ca@localhost>]

Great work! One small remark:

	+static int
	+ave_fdt_match(device_t parent, cfdata_t cf, void *aux)
	+{
	+       static const char * compatible[] = {
	+#ifdef _LP64
	+               "socionext,unifier-ld20-ave4",
	+#else
	+               "socionext,unifier-pro4-ave4",
	+               "socionext,unifier-pxs2-ave4",
	+               "socionext,unifier-ld11-ave4",
	+               "socionext,unifier-pxs3-ave4",
	+#endif
	+               NULL
	+       };

Please do not use #ifdef here. Compatible strings are meant to describe 
which hardware device the driver is compatible with, and can be shared 
across multiple SoCs. In the case of IP licensing, possibly not even in 
the same SoC family! Consider a hypothetical where Socionext could release 
a new 32-bit SoC with an ave(4) that is functionally identical to the one 
found in their previous 64-bit chip.