Re: CVS commit: src/sys/modules/examples/fopsmapper

[Jason Thorpe <thorpej%me.com@localhost>]

> On Apr 1, 2020, at 7:17 AM, Christos Zoulas <christos%astron.com@localhost> wrote:
> 
> Which we have been slowly fixing. I think in this case the sign-compare
> warnings are annoying, but putting casts on each warning is cluttering
> the code needlessly. Unfortunately the alternative (to make the PAGESIZE
> constant unsigned is more dangerous -- unless of course you are willing to 
> examine all the places it is used and make sure that the semantics don't
> change). Another way would be to make:
> 
>    #define PAGESIZE_U ((unsigned)PAGESIZE)

If PAGE_SIZE is ostensibly a vsize_t / size_t, why not define it as (1U << PAGE_SHIFT)?

-- thorpej