Re: CVS commit: src/sys/netinet6

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Apr 24, 2020 at 05:36:55PM +0000, Jonathan A. Kollasch wrote:
> Module Name:	src
> Committed By:	jakllsch
> Date:		Fri Apr 24 17:36:55 UTC 2020
> 
> Modified Files:
> 	src/sys/netinet6: in6_proto.c
> 
> Log Message:
> Fill in .pr_usrreqs for SOCK_SEQPACKET and SOCK_STREAM variants of SCTP too.
> 
> This should allow these socket types of SCTP to operate on IPv6 family
> sockets, as .pr_usrreqs must not be NULL for socreate() to succeed.

Thanks for this fix!

The one test program I know for sctp now gets further but fails in
setsockopt (with a basically GENERIC/amd64 5.99.57 kernel).

Test program:

hg clone http://www.freediameter.net/hg/freeDiameter
cd freeDiameter
mkdir build
cd build
cmake ..
make
./tests/testsctp

gives:
09:53:15  FATAL! sctp.c:101: CHECK FAILED : fd_sctp_client( &cli.cc_socket, 0, TEST_PORT, &eps ) == 2d != 0

Line 101 is
                CHECK_SYS(  setsockopt(sk, IPPROTO_SCTP, SCTP_RTOINFO, &rtoinfo, sizeof(rtoinfo))  );

Cheers,
 Thomas