Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/libexec/httpd



thanks for this.  please cc me directly for bozohttpd changes,
i have a couple review comments :-)

> Committed By:	jruoho
> Date:		Sat Jul 11 08:10:52 UTC 2020
> 
> Modified Files:
> 	src/libexec/httpd: Makefile auth-bozo.c bozohttpd.8 bozohttpd.c
> 	    bozohttpd.h
> 
> Log Message:
> Add blocklistd(8) support.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.28 -r1.29 src/libexec/httpd/Makefile
> cvs rdiff -u -r1.24 -r1.25 src/libexec/httpd/auth-bozo.c
> cvs rdiff -u -r1.80 -r1.81 src/libexec/httpd/bozohttpd.8
> cvs rdiff -u -r1.115 -r1.116 src/libexec/httpd/bozohttpd.c
> cvs rdiff -u -r1.61 -r1.62 src/libexec/httpd/bozohttpd.h

please add -DNO_BLOCKLIST_SUPPORT to Makefile.boot.

i'm not sure i agree about 500 -> abusive behaviour.  that's
when there's some _internal_ error and could just as easily
be caused by a human or code error on the server side.

i don't know blocklist well enough to suggestion what we 
should do here, but this feels wrong to me.

thanks again.


.mrg.


Home | Main Index | Thread Index | Old Index