Re: CVS commit: src/sys/crypto/aes

[Roy Marples <roy%marples.name@localhost>]

On 27/07/2020 21:44, Taylor R Campbell wrote:
> Module Name:	src
> Committed By:	riastradh
> Date:		Mon Jul 27 20:44:30 UTC 2020
>
> Modified Files:
> 	src/sys/crypto/aes: aes_ccm.c aes_ccm.h
>
> Log Message:
> Gather auth[16] and ctr[16] into one authctr[32].
>
> Should appease clang.

clang is still not appeased :/

--- aes_via.o ---
/home/roy/src/hg/src/sys/crypto/aes/arch/x86/aes_via.c:807:6: error: variable 
'authctr' is used uninitialized whenever 'if' condition is false 
[-Werror,-Wsometimes-uninitialized]
        if ((uintptr_t)authctr0 & 0xf) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~
/home/roy/src/hg/src/sys/crypto/aes/arch/x86/aes_via.c:820:10: note: 
uninitialized use occurs here
        be32enc(authctr + 16 + 4*3, ++c3);
                ^~~~~~~
/home/roy/src/hg/src/sys/crypto/aes/arch/x86/aes_via.c:807:2: note: remove the 
'if' if its condition is always true
        if ((uintptr_t)authctr0 & 0xf) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/roy/src/hg/src/sys/crypto/aes/arch/x86/aes_via.c:796:18: note: initialize 
the variable 'authctr' to silence this warning
        uint8_t *authctr;
                        ^
                         = NULL
1 error generated.
*** [aes_via.o] Error code 1