Re: CVS commit: src/sys/arch/aarch64/aarch64

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

Hi,

On 2020/10/01 1:35, Nick Hudson wrote:
> Module Name:	src
> Committed By:	skrll
> Date:		Wed Sep 30 16:35:49 UTC 2020
>
> Modified Files:
> 	src/sys/arch/aarch64/aarch64: cpuswitch.S vectors.S
>
> Log Message:
> Move el[01]_trap_exit into vectors.S where the callers exist
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.27 -r1.28 src/sys/arch/aarch64/aarch64/cpuswitch.S
> cvs rdiff -u -r1.18 -r1.19 src/sys/arch/aarch64/aarch64/vectors.S
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

This commit seems to break COMPAT_NETBSD32. On RPI3, earmv7hf binaries
get SIGSEGV:

---
# uname -a
NetBSD  9.99.73 NetBSD 9.99.73 (GENERIC64) #33: Mon Oct  5 23:26:29 JST 2020  rin@latipes:/sys/arch/evbarm/compile/GENERIC64 evbarm
# file /emul/netbsd32/bin/sh
/emul/netbsd32/bin/sh: ELF 32-bit LSB pie executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /libexec/ld.elf_so, for NetBSD 9.99.73, compiled for: earmv7hf, not stripped
# /emul/netbsd32/bin/sh
[1]   Segmentation fault (core dumped) /emul/netbsd32/bin/sh
# ktrace /emul/netbsd32/bin/sh
[1]   Segmentation fault (core dumped) ktrace /emul/netbsd32/bin/sh
# kdump | tail
   171    171 sh       CALL  netbsd32_break(0xb74ffdc)
   171    171 sh       RET   netbsd32_break 0
   171    171 sh       CALL  netbsd32___clock_gettime50(3,0xfff997f8)
   171    171 sh       RET   netbsd32___clock_gettime50 0
   171    171 sh       CALL  netbsd32___clock_gettime50(3,0xfff997f8)
   171    171 sh       RET   netbsd32___clock_gettime50 0
   171    171 sh       CALL  netbsd32___clock_gettime50(3,0xfff99810)
   171    171 sh       RET   netbsd32___clock_gettime50 0
   171    171 sh       PSIG  SIGSEGV SIG_DFL: code=SEGV_MAPERR, addr=0x8, trap=-1845493754)
   171    171 sh       NAMI  "sh.core"
---

Full kdump is provided here:

	http://www.netbsd.org/~rin/aarch64_netbsd32_kdump_20201006.txt

By reverting this commit, arm32 binaries become working again.
Can you take a look please?

Thanks,
rin