Re: CVS commit: src

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Sun, Nov 08, 2020 at 09:56:48PM +0000, Nia Alarie wrote:
> Module Name:	src
> Committed By:	nia
> Date:		Sun Nov  8 21:56:48 UTC 2020
> 
> Modified Files:
> 	src/external/bsd/kyua-cli: Makefile.inc
> 	src/external/ibm-public/postfix: Makefile.inc
> 	src/external/public-domain/sqlite: Makefile.inc
> 	src/external/public-domain/sqlite/bin: Makefile
> 	src/external/public-domain/sqlite/lib: Makefile sqlite3.pc.in
> 	src/usr.sbin/makemandb: Makefile
> 
> Log Message:
> sqlite: do not build without multithreading support

So the core issue here is that it actually does two separate things. It
does not only enable threadsafety (which is good), but also enables the
worker thread support (which is bad). There is little reason for wanting
the latter in a general build, at least the way it is implemented right
now. Just doing the former is a lot less intrusive...

Joerg

diff -r 2bb2635be785 external/public-domain/sqlite/Makefile.inc
--- a/external/public-domain/sqlite/Makefile.inc	Thu Nov 12 23:24:18 2020 +0100
+++ b/external/public-domain/sqlite/Makefile.inc	Thu Nov 12 23:28:36 2020 +0100
@@ -15,6 +15,7 @@
 		-DHAVE_STRERROR_R=1 \
 		-DHAVE_USLEEP=1 \
 		-DHAVE_SYS_ENDIAN_H=1 \
+		-DSQLITE_THREADSAFE \
 		-DSQLITE_MAX_WORKER_THREADS=0 \
 		-DSQLITE_ENABLE_COLUMN_METADATA \
 		-DSQLITE_ENABLE_FTS3_PARENTHESIS \