Re: CVS commit: src/usr.bin/xlint/lint1

[Jared McNeill <jmcneill%invisible.ca@localhost>]

Not sure if it is this exact change, but I am no longer able to build 
tools on Ubuntu 20.04.1:

--- lint1 ---
#      link  lint1/lint1
cc -O -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 
-I/home/jmcneill/netbsd/cvs-src/obj/tooldir.Linux-5.8.0-34-generic-x86_64/include/compat 
-I/home/jmcneill/netbsd/cvs-src/tools/compat -DHAVE_NBTOOL_CONFIG_H=1 
-D_FILE_OFFSET_BITS=64 
-I/home/jmcneill/netbsd/cvs-src/tools/lint1/../../usr.bin/xlint/lint1 -I. 
-DPASS=\"lint1.h\" 
-I/home/jmcneill/netbsd/cvs-src/tools/lint1/../../usr.bin/xlint/lint1/../arch/aarch64 
-I/home/jmcneill/netbsd/cvs-src/tools/lint1/../../usr.bin/xlint/lint1/../common 
-o lint1 cgram.lo decl.lo emit.lo emit1.lo err.lo func.lo init.lo 
inittyp.lo main1.lo mem.lo mem1.lo ops.lo print.lo scan.lo tree.lo 
tyname.lo 
-L/home/jmcneill/netbsd/cvs-src/obj/tooldir.Linux-5.8.0-34-generic-x86_64/lib 
-lnbcompat -lrt -lz -lm
/usr/bin/ld: ops.lo: in function `initmtab':
ops.c:(.text+0x63): undefined reference to `STRUCT_ASSIGN'
collect2: error: ld returned 1 exit status
*** [lint1] Error code 1

nbmake[3]: stopped in /home/jmcneill/netbsd/cvs-src/tools/lint1
1 error

nbmake[3]: stopped in /home/jmcneill/netbsd/cvs-src/tools/lint1

nbmake[2]: stopped in /home/jmcneill/netbsd/cvs-src/tools/lint1

*** Failed target:  dependall-lint1
*** Failed command: _makedirtarget() { dir="$1"; shift; target="$1"; 
shift; case "${dir}" in /*) this="${dir}/"; real="${dir}" ;; .) this=""; 
real="/home/jmcneill/netbsd/cvs-src/tools" ;; *) this="${dir}/"; 
real="/home/jmcneill/netbsd/cvs-src/tools/${dir}" ;; esac; 
show=${this:-.}; echo "${target} ===> ${show%/}${1:+ (with: $@)}"; cd 
"${real}" && 
/home/jmcneill/netbsd/cvs-src/obj/tooldir.Linux-5.8.0-34-generic-x86_64/bin/nbmake 
_THISDIR_="${this}" "$@" ${target}; }; _makedirtarget lint1 dependall
*** Error code 2

Stop.
nbmake[1]: stopped in /home/jmcneill/netbsd/cvs-src/tools
*** [build_install] Error code 1

nbmake: stopped in /home/jmcneill/netbsd/cvs-src/tools
1 error

nbmake: stopped in /home/jmcneill/netbsd/cvs-src/tools

ERROR: Failed to make build_install in "tools"
*** BUILD ABORTED ***


On Tue, 5 Jan 2021, Roland Illig wrote:

> Module Name:	src
> Committed By:	rillig
> Date:		Tue Jan  5 23:50:29 UTC 2021
>
> Modified Files:
> 	src/usr.bin/xlint/lint1: Makefile op.h ops.def
> Added Files:
> 	src/usr.bin/xlint/lint1: ops.c
> Removed Files:
> 	src/usr.bin/xlint/lint1: Makefile.ops-c Makefile.ops-h mkops
>
> Log Message:
> lint: clean up generation of the operator tables
>
> Instead of running a shell program that runs an AWK program that
> generates the two files ops.c and ops.h, just define the operator tables
> once in ops.def and use these definitions flexibly in ops.c and op.h.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.55 -r1.56 src/usr.bin/xlint/lint1/Makefile
> cvs rdiff -u -r1.3 -r0 src/usr.bin/xlint/lint1/Makefile.ops-c \
>    src/usr.bin/xlint/lint1/Makefile.ops-h
> cvs rdiff -u -r1.13 -r0 src/usr.bin/xlint/lint1/mkops
> cvs rdiff -u -r1.9 -r1.10 src/usr.bin/xlint/lint1/op.h
> cvs rdiff -u -r0 -r1.1 src/usr.bin/xlint/lint1/ops.c
> cvs rdiff -u -r1.6 -r1.7 src/usr.bin/xlint/lint1/ops.def
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.