Re: CVS commit: src/sys/compat/netbsd32

[Roy Marples <roy%marples.name@localhost>]

Hi Simon

On 17/01/2021 11:26, Simon Burge wrote:
> > On 15/01/2021 07:15, matthew green wrote:
> > > > Oh, I quite agree. However, in6_nbrinfo predates my involvement with NetBSD
> > > > and is the same struct on all BSD. While bringing the same functionality to
> > > > IPv4, I elected to keep the same struct just to have the same API, warts
> > > > and all. I like consistency.
>
> Does anyone else have an in_nbrinfo?  I _think_ the "asked" member only
> seems to get assigned a 0 for ipv4, and with a long being 32-bits on any
> 32 bit platform making it a long instead of an int doesn't buy anything.

No, it's currently unique to NetBSD.
Other BSD's just don't have the infrastructure in their network for it either.
I'll note that on a 64-bit platform it's 64 bits though so these do gains something.

The value is similar to struct if_data counters really, so maybe it should be a 
uint64_t if you really want to change it.
I would then argue that it might be better then to version it proper and move it 
out of compat32.

> I'm still keen to make this change (asked as an int instead of a long in
> in_nbrinfo) and announce a mini flag day for arp for -current users so
> that it's one less compat32 ioctl we have to maintain.

I would just like arp to work without error.
My personal preference would be to keep the same API and add compat.

> I've committed compat32 support for SIOCGNBRINFO_IN6 and in6_nbrinfo.

Looks great!
Also looks the same as what I did but couldn't get to work.
Maybe I missed the netbsd32 on the long.

Roy