Re: CVS commit: src/sys/kern (kern_event.c)

[Paul Goyette <paul%whooppee.com@localhost>]

On Thu, 21 Jan 2021, Paul Goyette wrote:

> Ooopppsss ignore me - looks like this was already fixed and my update
> missed it.
>
> I'll retry.

OK, I built and installed a new kernel+userland.

Most everything works, and syslogd seems to work fine (at least, it
no longer panics during startup).

HOWEVER, firefox seems to be badly broken.  Attempting to open certain
pages results in never-ending-hang, and nothing ever gets rendered.  I
can use the Stop-Reloading "X" button, and the "oscillating dot" load
indicator stops oscillating, but nothing ever happens.  At that point,
the tab is hung and cannot load any other page, not even pages that
loaded successfully previously!  I _can_ delete the tab, and opening a
new tab works.

Some of the "failing" pages are:

	airnow.gov
	gmail.com
	www.prudential.com/login
	www.myaccountviewonline.com/AccountView/Logon


Slight correction:  above I said "nothing ever happens" but while I've
been composing this Email a couple of the above pages seem to have made
some progress (although none of them have finished and stopped the
"oscillating dot").  So "ever" is at least 5 minutes or longer ...  :)


I don't know if the kern_event.c changes are responsible, but I haven't
seen anything else recently.

FWIW, I'm running firefox 83.0 from pkgsrc, around 2020-12-08


> On Thu, 21 Jan 2021, Paul Goyette wrote:
>
> > This change seems to break everything!  As soon as I try to start
> > syslogd I hit the panic() that you added....
> >
> > [  28.0253983] panic: kqueue_scan,1491: kq=0xffffdc13890bc4c0 
> > kq->kq_count(1) != count(0), nmarker=1
> >
> > [  28.0253983] cpu0: Begin traceback...
> > [  28.0253983] vpanic() at netbsd:vpanic+0x156
> > [  28.0253983] snprintf() at netbsd:snprintf
> > [  28.0253983] kqueue_check() at netbsd:kqueue_check+0x183
> > [  28.0253983] kevent1() at netbsd:kevent1+0x49f
> > [  28.0253983] sys___kevent50() at netbsd:sys___kevent50+0x33
> > [  28.0253983] syscall() at netbsd:syscall+0x23e
> > [  28.0253983] --- syscall (number 435) ---
> > [  28.0253983] netbsd:syscall+0x23e:
> > [  28.0253983] cpu0: End traceback...
> > [  28.0253983] fatal breakpoint trap in supervisor mode
> > [  28.0253983] trap type 1 code 0 rip 0xffffffff8021f415 cs 0x8 rflags 
> > 0x202 cr2 0x78742459e000 ilevel 0x8 rsp 0xffffa809281ebb50
> > [  28.0253983] curlwp 0xffffdc138aa46540 pid 1352.1352 lowest kstack 
> > 0xffffa809281e72c0
> > Stopped in pid 1352.1352 (syslogd) at   netbsd:breakpoint+0x5:  leave
> >
> > I have a full crash dump if you need any further info.
> >
> >
> > Module Name:    src
> > Committed By:   jdolecek
> > Date:           Thu Jan 21 18:09:23 UTC 2021
> >
> > Modified Files:
> >        src/sys/kern: kern_event.c
> >
> > Log Message:
> > adjust kq_check() (enabled with DEBUG) to new reality - it's now perfectly
> > normal to have kq_count bigger than number of the linked entries
> > on the kqueue
> >
> > PR kern/50094, problem pointed out by Chuck Silvers
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.111 -r1.112 src/sys/kern/kern_event.c
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> >
> >
> > +--------------------+--------------------------+-----------------------+
> > | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
> > | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
> > | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
> > +--------------------+--------------------------+-----------------------+
>
> +--------------------+--------------------------+-----------------------+
> | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
> | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
> | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
> +--------------------+--------------------------+-----------------------+

+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+