Re: CVS commit: src/sys/dev/pci

[christos%astron.com@localhost (Christos Zoulas)]

In article <17141.1611452223%splode.eterna.com.au@localhost>,
matthew green  <mrg%eterna.com.au@localhost> wrote:
>Christos Zoulas writes:
>> In article <20210123230600.52BE16085E%jupiter.mumble.net@localhost>,
>> Taylor R Campbell  <campbell+netbsd-source-changes-d%mumble.net@localhost> wrote:
>> >
>> >Conversely, how do you know whether this hacked-up implementation
>> >which tears the write into two will actually work?  Maybe it works for
>> >virtio but there are likely other devices out there for which it will
>> >fail or have weird side effects if the architecture doesn't have
>> >native 8-byte bus I/O.
>>
>> But it is a static function defined in virtio_pci.c. How will other
>> devices use it? I must be missing something.
>
>it's a bad example.  someone might copy it into another
>driver that _doesn't_ work with this version, but may seem
>to fix a build error.
>
>that's why i wanted to wrap the usage to make it clear if
>someone were to copy it elsewhere.

I will add a comment.

christos