Re: CVS commit: src

[Roland Illig <roland.illig%gmx.de@localhost>]

Tom Ivar Helbekkmo <tih%hamartun.priv.no@localhost> wrote:
> Christos Zoulas <christos%netbsd.org@localhost> writes:
>
>> Module Name:  src
>> Committed By: christos
>> Date:   Sun Aug 29 09:54:18 UTC 2021
>>
>> Modified Files:
>>   src/distrib/sets/lists/debug: mi
>>   src/distrib/sets/lists/tests: mi
>>   src/etc/mtree: NetBSD.dist.tests
>>   src/tests/usr.sbin: Makefile
>>   src/usr.sbin/inetd: Makefile inetd.8 inetd.c
>> Added Files:
>>   src/tests/usr.sbin/inetd: Makefile inetd_ratelimit.conf t_inetd.c
>>       test_server.c
>>   src/usr.sbin/inetd: inetd.h parse_v2.c
>
> parse_v2.c contains a couple of comparisons of char values to -1.  On
> arm, this fails to build, because the compiler observes that those
> comparisons are always false.

Nice catch. This is something that lint already warns about (see tests/usr.bin/xlint/lint1/msg_230.c), it's just not enabled for usr.sbin. A few days ago I enabled it for usr.bin, will do the same for other directories as well.