Re: CVS commit: src/crypto/external/bsd/openssh/dist

[Taylor R Campbell <campbell+netbsd-source-changes-d%mumble.net@localhost>]

> Date: Mon, 6 Sep 2021 22:32:22 +0900
> From: Rin Okuyama <rokuyama.rk%gmail.com@localhost>
> 
> On 2021/09/06 22:11, Ryo ONODERA wrote:
> > Module Name:	src
> > Committed By:	ryoon
> > Date:		Mon Sep  6 13:11:34 UTC 2021
> > 
> > Modified Files:
> > 	src/crypto/external/bsd/openssh/dist: dns.c
> > 
> > Log Message:
> > Make no diff to upstream
> 
> This diff from upstream is intentional. See:
> 
> http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssh/dist/dns.c#rev1.6
> http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssh/dist/dns.c#rev1.7

At the time, I think upstream used memcmp, so anything different from
that was a local change.  Now our libc has consttime_memequal, and
upstream uses a similar function called timingsafe_bcmp, so as long as
timingsafe_bcmp is defined in terms of consttime_memequal (and not in
terms of memcmp or bcmp), reducing this local diff strikes me as an
improvement (speaking as the author of the original local change).