Re: CVS commit: src/sys/arch/i386/stand/efiboot

[Simon Burge <simonb%NetBSD.org@localhost>]

Hi Emmanuel,

"Emmanuel Dreyfus" wrote:

> Module Name:	src
> Committed By:	manu
> Date:		Thu Nov 18 16:18:13 UTC 2021
>
> Modified Files:
>
> 	src/sys/arch/i386/stand/efiboot: devopen.c
>
> Log Message:
>
> Fix crash because of NULL pointer reference

What crash did this fix?  All the use of part_name by the
called functions should check if it is NULL before trying
to assign anything to *part_name.

This change has broken loading boot.cfg via the EFI path
"esp:/EFI/NetBSD/boot.cfg" since the call to bios_boot() at
https://nxr.netbsd.org/xref/src/sys/arch/i386/stand/efiboot/devopen.c#292
with a non-NULL last argument means devname gets updated and
now points to the partition with a root filesystem rather
than the EFI system partition.

Cheers,
Simon.