Re: CVS commit: xsrc/external/mit/xinit/dist

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

On Wed, Dec 29, 2021 at 07:42:42 +0300, Valery Ushakov wrote:

> On Wed, Dec 29, 2021 at 15:09:08 +1100, matthew green wrote:
> 
> > "Nia Alarie" writes:
> > > Module Name:	xsrc
> > > Committed By:	nia
> > > Date:		Tue Dec 28 11:48:52 UTC 2021
> > >
> > > Modified Files:
> > > 	xsrc/external/mit/xinit/dist: xinitrc.cpp
> > >
> > > Log Message:
> > > COLOR is not a C preprocessor macro :|
> > 
> > this used to work a long long time ago.  back when
> > sunos4 was not entirely obsolete :-)
> 
> I actually still have #ifdef COLOR in my resources carried around from
> that time, but the it's been quite a long ago that I used an actual
> b/w (1bpp) display where this actually mattered.  Any VAXstation users
> around?  Also, why not arrange for COLOR to be defined?

Uhm, actually xrdb *does* define COLOR but it defines it without value

    switch (visual->class) {
    case StaticColor:
    case PseudoColor:
    case TrueColor:
    case DirectColor:
        AddSimpleDef(defs, "COLOR");
        break;
    }

so the right fix would be to just fix the #if in xinitrc to #ifdef

-uwe