Re: CVS commit: src/lib/libcurses

[Roland Illig <roland.illig%gmx.de@localhost>]

16.01.2022 12:44:02 Valery Ushakov <uwe%stderr.spb.ru@localhost>:

> On Sun, Jan 16, 2022 at 10:30:45 +0000, Roland Illig wrote:
> 
>> Modified Files:
>>     src/lib/libcurses: addbytes.c ins_wstr.c
>> 
>> Log Message:
>> libcurses: remove unreachable statements
> 
> That summary sounds kinda misleading to me.  It's technically true -
> the commit removes unreachable *empty* statements - accidentally
> doubled semicolons in return foo;; and the like - but it makes it
> sound much more ominous by failing to mention that fact.  I would have
> skipped a change summarized, e.g., as "g/c duplicate semicolons" or
> something like that that actually captured the essense of the change
> correctly.  I felt compelled to go and take a look at something
> described as "remove unreachable statements".  Please, can you be more
> careful in wording those?


Actually, I _was_ careful.  I not only removed 2 null statements (as the C standard calls them) but also an unreachable break statement.  Due to this break statement it would have been misleading (at least to me) to only state "remove empty statements" or even "remove duplicate semicolons".

I'm not sure what the perfect commit message would look like that would keep us both unsurprised and how much time we should spend discussing about this particular case since the code itself can be reviewed in a few seconds.

Roland