Re: CVS commit: src/sys/kern

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Sat, 5 Feb 2022 15:17:40 +0000
Martin Husemann <martin%netbsd.org@localhost> wrote:

> Modified Files:
> 	src/sys/kern: subr_autoconf.c
> 
> Log Message:
> cfdriver_iattr_count() is only used in a KASSERT, so #ifdef DIAGNOSTIC it.

This doesn't seem to work as intended.
In a kernel with "no options DIAGNOSTIC" I now get:

/work/src/sys/kern/subr_autoconf.c: In function 'config_search_internal':
/work/src/sys/kern/subr_autoconf.c:1149:3: error: implicit declaration of function 'cfdriver_iattr_count' [-Werror=implicit-function-declaration]
 1149 |   cfdriver_iattr_count(parent->dv_cfdriver) < 2);
      |   ^~~~~~~~~~~~~~~~~~~~
/work/src/sys/lib/libkern/libkern.h:279:42: note: in definition of macro 'KASSERT'
  279 | #define KASSERT(e)  ((void)sizeof((long)(e)))