Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libc/time



In article <977b81a4-d330-6722-7ce4-cc4e61011221%gmx.de@localhost>,
Roland Illig  <roland.illig%gmx.de@localhost> wrote:
>Am 25.03.2022 um 22:25 schrieb Christos Zoulas:
>> In article <20220325183551.0F039FB32%cvs.NetBSD.org@localhost>,
>> Roland Illig <source-changes-d%NetBSD.org@localhost> wrote:
>>> -=-=-=-=-=-
>>>
>>> Module Name:	src
>>> Committed By:	rillig
>>> Date:		Fri Mar 25 18:35:50 UTC 2022
>>>
>>> Modified Files:
>>> 	src/lib/libc/time: localtime.c
>>>
>>> Log Message:
>>> localtime.c: add back storage class 'register'
>>>
>>> This reduces the differences to the upstream code.
>>
>> I don't know why you did that. It is as simple to sed -e 's/register //g'
>> in upstream when you diff. Adding register is useless; these days it is
>> mostly ignored by compilers, except you can't &...
>
>I thought that having a small diff to the upstream code was more
>important than a few saved keywords.  If I was wrong, I can of course
>revert it.

I don't care too much, less clutter without obsolete keywords that do
nothing or worse.

christos



Home | Main Index | Thread Index | Old Index