Re: CVS commit: src/sbin/raidctl

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Sat, 18 Jun 2022 14:45:12 -0000 (UTC)
    From:        christos%astron.com@localhost (Christos Zoulas)
    Message-ID:  <t8kodo$11d4$1%ciao.gmane.io@localhost>

  | Nevertheless why don't we make the char one unsigned char?

I wondered about that possibility, but it was a bigger change than I
wanted to make at the time - I didn't want to have to even consider
the potential flow on cleanup changes that come from switching from
signed to unsigned.

It would be cleaner however - a quick skim of the source suggested to
me that anything <= 0 is treated as 1 in any case, so (if that is
correct) there's certainly no point in allowing negative values.

kre

ps: my raid5 is working fine with its -56 queue length!

Component label for /dev/dk21:
   Row: 0, Column: 0, Num Rows: 1, Num Columns: 3
   Version: 2, Serial Number: 19591006, Mod Counter: 1772
   Clean: No, Status: 0
   sectPerSU: 32, SUsPerPU: 1, SUsPerRU: 1
   Queue size: -56, blocksize: 512, numBlocks: 27344762880
   RAID Level: 5