re: CVS commit: src/sys/dev/pci

[Paul Goyette <paul%whooppee.com@localhost>]

On Sat, 9 Jul 2022, matthew green wrote:

> "Paul Goyette" writes:
> > Module Name:	src
> > Committed By:	pgoyette
> > Date:		Fri Jul  8 17:32:19 UTC 2022
> >
> > Modified Files:
> > 	src/sys/dev/pci: nvme_pci.c
> >
> > Log Message:
> > devsw_ok needs to survive across invocations of nvme_modcmd() so
> > allocate it statically.
> >
> > Should address remaining issues with kern/56914
>
>                if (error) {
> +                       devsw_ok = false;
>
>
> shouldn't devsw_ok be "false" here already?  seems more like
> something to ASSERT() than assign.

Yeah, this is likely unnecessary now.  It got there during a
debug iteration.

I will remove.


+--------------------+--------------------------+----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:    |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost    |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost  |
| & Network Engineer |                          | pgoyette99%gmail.com@localhost |
+--------------------+--------------------------+----------------------+