Re: CVS commit: src

[Brook Milligan <brook%nmsu.edu@localhost>]

> On Aug 22, 2022, at 5:47 AM, Martin Husemann <martin%duskware.de@localhost> wrote:
> 
> On Sun, Aug 21, 2022 at 03:01:08PM +0000, Brook Milligan wrote:
>> Create bootable images in ${RELEASEDIR}/${RELEASEMACHINEDIR}/binary/gzimg.
>> ${RELEASEDIR}/${RELEASEMACHINEDIR}/binary/gzimg.  If a boot block is
>> not available, which is the typical situation currently, no additional
>> image will be created.
> 
> I like this option, but I don't like that it is not optional.
> 
> IIUC the release build will now create different output depending on
> what u-boot packages might accidently be installed in /usr/pkg/share/u-boot
> on the build host.
> 
> This is not good, there should be an explicit build.sh option needed,
> or INSTALLBOOT_BOARDS should not have any default.

I was wondering about that, but received zero feedback from my post to current-users [1].

INSTALLBOOT_BOARDS is constructed dynamically from installboot, so it is not really part of the current user interface.  

Alternatives are a build.sh option or special handling for INSTALLBOOT_UBOOT_PATHS.  The former adds more complication to the script and the latter would require replacing the environment variable with nonsense (e.g., /nonexistent) if empty and forcing users to explicitly choose paths (including /usr/pkgsrc) if they want this (which is not the default behavior for installboot by itself).  Perhaps there are other options, like inventing yet another environment variable?

I am currently thinking that INSTALLBOOT_BOARDS should be a list of boards to install (empty meaning none) or “none” (same as empty), or “all”, in which case it will be generated by installboot as now.

Any suggestions?

Cheers,
Brook

[1] http://mail-index.netbsd.org/current-users/2022/07/10/msg042638.html