Re: CVS commit: src/sys/dev/i2c

[Simon Burge <simonb%NetBSD.org@localhost>]

Hi Brad,

> Module Name:	src
> Committed By:	brad
> Date:		Tue Nov 22 19:40:31 UTC 2022
>
> Modified Files:
>
> 	src/sys/dev/i2c: bmx280.c
>
> Log Message:
>
> Read the datasheet more closely and put in some delays.  The chip will
> just return junk if the wait is not long enough to allow a measurement
> to start.


+       /* Hmm... this delay is not documented well..  mostly just a guess...
+        * If it is too short, you will get junk returned as it is possible to try
+        * to ask for the data before the chip has even started... it seems...
+        */
+       delay(35000);

This will spin for 35 milliseconds (per sensor read if I read this
correctly).  Can you please look at using kpause(9) for this delay?
See some other i2c drivers for examples of this.

Cheers,
Simon.