Re: CVS commit: src/share/misc

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

On Thu, Mar 30, 2023 at 10:39:31 +0000, Taylor R Campbell wrote:

> Modified Files:
> 	src/share/misc: style
> 
> Log Message:
> style(5): Forbid extern in .c files.
> 
> Discussed on tech-userlevel (bcc tech-kern):
> https://mail-index.netbsd.org/tech-userlevel/2023/03/15/msg013727.html

I quite agree with the intention, but the example is still very
confusing IMO.  The second hunk is non-sequitur, b/c it talks about
file scope externs ("in *.c files") at the location where an extern
declaration would be a nested extern.  Also, in the new file there are
no actual extern declarations there, so the new comment looks
completely out of place.

You have never replied to my comments about this when this was
discussed on the mailing list.

-uwe