Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/news68k/conf



> In this case maybe I should remove all FPSP references (vectors.S,
> locore.S, Makefile.news68k (MD_LIBS={FPSP})?

IMO we don't have to keep strict consistencies or buildabilities of
options but rather should consider readabilities and maintainabilities.

- options FPSP in a config file is not necessary for users on news68k
  (unless some users build own 040/060 upgrade mod like x68k)
- #ifdef FPSP (and other m68k specific options) blocks in common
  sources might help to check diffs from other m68k ports
 - In the perfect world, we should have a common m68k/locore.s etc.
   and move port specific blocks into locore_machdep.s like mips,
   but m68k CPUs are too flexible and all m68k ports have too many
   historical difficulties to refactor them

I don't mind your changes in this case, but it's appreciated
to ask design considerations before changes, as you did for mmeye.

Thanks,
---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index