re: CVS commit: src/external/mit/xorg/lib

[matthew green <mrg%eterna23.net@localhost>]

"Taylor R Campbell" writes:
> Module Name:	src
> Committed By:	riastradh
> Date:		Sun May  5 15:25:31 UTC 2024
>
> Modified Files:
> 	src/external/mit/xorg/lib/dri: Makefile
> 	src/external/mit/xorg/lib/dri.old: Makefile
>
> Log Message:
> mesa: Build with -Wno-error=typedef-redefinition.
>
> While here, use CWARNFLAGS.clang instead of an explicit conditional.
>
> In file included from 110_blorp_exec.c:33:
> In file included from /home/source/ab/HEAD-llvm/xsrc/external/mit/MesaLib/dist/src/intel/blorp/blorp_genX_exec.h:27:
> In file included from /home/source/ab/HEAD-llvm/xsrc/external/mit/MesaLib/dist/src/intel/blorp/blorp_priv.h:30:
> /home/source/ab/HEAD-llvm/xsrc/external/mit/MesaLib/dist/src/compiler/nir/nir.h:3840:3: error: redefinition of typedef 'nir_shader' is a C11 feature [-Werror
> ,-Wtypedef-redefinition]
> } nir_shader;
>   ^
> /home/source/ab/HEAD-llvm/xsrc/external/mit/MesaLib/dist/src/intel/compiler/brw_compiler.h:41:27: note: previous definition is here
> typedef struct nir_shader nir_shader;

actually, this really is a valid warning and the real fix is to not
compile this with -std=gnu99 (or is it gnu+99), but use the default
for some and maybe gnu++17 for some parts, going on what the real
build for this does.

not sure why you changed dri.old/Makefile.  it wasn't a problem.

i was testing the real fix and i'll revert these when it's in.


.mrg.