Re: CVS commit: src/lib/libm

[Nathanial Sloss <nathanialsloss%yahoo.com.au@localhost>]

On Tue, 29 Oct 2024 23:30:47 Taylor R Campbell wrote:
> > Module Name:    src
> > Committed By:   nat
> > Date:           Tue Oct 29 01:34:18 UTC 2024
> > 
> > Modified Files:
> >         src/lib/libm: Makefile
> > 
> > Log Message:
> > Pull in missing functions for MKSOFTFLOAT.
> 
> That's interesting, how did you notice these were missing?  What build
> does this affect?

mac68k MKSOFTFLOAT.
> 
> I'm surprised because I thought the libm build checked the _exact_ set
> of global dynamic symbols defined by libm.so, so if anything was
> missing it should be detected at build-time -- and if anything was
> added without updating a corresponding .expsym file, it should break
> the build.

That's exactly what happened the expected symbols did not match those in libm 
functions were missing.  The build broke for m68k soft float without this 
change.  As you can see I only added this to the m68k section.  The expected 
file required nexttoward and s_rintl and similar to be apart of libm.

Best regards,

Nat