[src/trunk]: src/sys/dev/pci/ixgbe Don't check IFF_RUNNING in ixgbe_rxeof(). ...

[msaitoh <msaitoh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/1d677353bbf7
branches:  trunk
changeset: 319259:1d677353bbf7
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Wed May 23 04:45:24 2018 +0000

description:
Don't check IFF_RUNNING in ixgbe_rxeof(). Doing break and leaving a deacriptor
with DD bit is worse than just processing the entry. And it's also racy to
check IFF_RUNNING in rxeof(). If you'd like to strictly obey IFF_RUNNING,
it would be better to do it in the upper layer.

 Same as DragonFly (a part of 79251f5ebe4cf9dd2f3e6aed590e09d756d39922).

diffstat:

 sys/dev/pci/ixgbe/ix_txrx.c |  4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diffs (18 lines):

diff -r fef1bb00aa9a -r 1d677353bbf7 sys/dev/pci/ixgbe/ix_txrx.c
--- a/sys/dev/pci/ixgbe/ix_txrx.c       Wed May 23 04:37:13 2018 +0000
+++ b/sys/dev/pci/ixgbe/ix_txrx.c       Wed May 23 04:45:24 2018 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: ix_txrx.c,v 1.45 2018/05/18 10:09:02 msaitoh Exp $ */
+/* $NetBSD: ix_txrx.c,v 1.46 2018/05/23 04:45:24 msaitoh Exp $ */
 
 /******************************************************************************
 
@@ -1833,8 +1833,6 @@
 
                if ((staterr & IXGBE_RXD_STAT_DD) == 0)
                        break;
-               if ((ifp->if_flags & IFF_RUNNING) == 0)
-                       break;
 
                count--;
                sendmp = NULL;