[src/trunk]: src/sys/compat/svr4_32 'error' is not set on failure. Which mean...

[maxv <maxv%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/508580ce1b27
branches:  trunk
changeset: 328598:508580ce1b27
user:      maxv <maxv%NetBSD.org@localhost>
date:      Wed Apr 09 11:40:03 2014 +0000

description:
'error' is not set on failure. Which means that if copyout() fails, 0
will be returned while the stack is not ready. This is a bug.

diffstat:

 sys/compat/svr4_32/svr4_32_exec_elf32.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 6b697e0d277c -r 508580ce1b27 sys/compat/svr4_32/svr4_32_exec_elf32.c
--- a/sys/compat/svr4_32/svr4_32_exec_elf32.c   Wed Apr 09 10:21:35 2014 +0000
+++ b/sys/compat/svr4_32/svr4_32_exec_elf32.c   Wed Apr 09 11:40:03 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: svr4_32_exec_elf32.c,v 1.22 2012/02/03 20:11:54 matt Exp $      */
+/*     $NetBSD: svr4_32_exec_elf32.c,v 1.23 2014/04/09 11:40:03 maxv Exp $      */
 
 /*-
  * Copyright (c) 1994 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: svr4_32_exec_elf32.c,v 1.22 2012/02/03 20:11:54 matt Exp $");
+__KERNEL_RCSID(0, "$NetBSD: svr4_32_exec_elf32.c,v 1.23 2014/04/09 11:40:03 maxv Exp $");
 
 #define        ELFSIZE         32                              /* XXX should die */
 
@@ -244,7 +244,7 @@
        a++;
 
        len = (a - ai) * sizeof(AuxInfo);
-       if (copyout(ai, *stackp, len))
+       if ((error = copyout(ai, *stackp, len)) != 0)
                return error;
        *stackp += len;