Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/fs/puffs According to pooka@'s comment, a long time ago, ...



details:   https://anonhg.NetBSD.org/src/rev/3c84849f7e51
branches:  trunk
changeset: 333378:3c84849f7e51
user:      manu <manu%NetBSD.org@localhost>
date:      Fri Oct 31 13:51:33 2014 +0000

description:
According to pooka@'s comment, a long time ago, VOP_STRATEGY could not
fail without taking down the kernel. It seems this is not the case anymore,
hence we can stop dropping errors in puffs_vnop_strategy()

Approved by pooka@

diffstat:

 sys/fs/puffs/puffs_vnops.c |  11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)

diffs (32 lines):

diff -r 764c00dbe1a6 -r 3c84849f7e51 sys/fs/puffs/puffs_vnops.c
--- a/sys/fs/puffs/puffs_vnops.c        Fri Oct 31 12:22:38 2014 +0000
+++ b/sys/fs/puffs/puffs_vnops.c        Fri Oct 31 13:51:33 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: puffs_vnops.c,v 1.194 2014/10/07 12:58:09 he Exp $     */
+/*     $NetBSD: puffs_vnops.c,v 1.195 2014/10/31 13:51:33 manu Exp $   */
 
 /*
  * Copyright (c) 2005, 2006, 2007  Antti Kantee.  All Rights Reserved.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: puffs_vnops.c,v 1.194 2014/10/07 12:58:09 he Exp $");
+__KERNEL_RCSID(0, "$NetBSD: puffs_vnops.c,v 1.195 2014/10/31 13:51:33 manu Exp $");
 
 #include <sys/param.h>
 #include <sys/buf.h>
@@ -2765,13 +2765,6 @@
                if (dobiodone == 0)
                        goto out;
 
-               /*
-                * XXXXXXXX: wrong, but kernel can't survive strategy
-                * failure currently.  Here, have one more X: X.
-                */
-               if (error != ENOMEM)
-                       error = 0;
-
                error = checkerr(pmp, error, __func__);
                if (error)
                        goto out;



Home | Main Index | Thread Index | Old Index