[src/trunk]: src/etc/rc.d Add new keytype, replace duplicated code with loop

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/30a7298ca808
branches:  trunk
changeset: 333115:30a7298ca808
user:      christos <christos%NetBSD.org@localhost>
date:      Sun Oct 19 16:33:01 2014 +0000

description:
Add new keytype, replace duplicated code with loop

diffstat:

 etc/rc.d/sshd |  64 +++++++++++++++++++++++-----------------------------------
 1 files changed, 26 insertions(+), 38 deletions(-)

diffs (88 lines):

diff -r 1f54c3b53e14 -r 30a7298ca808 etc/rc.d/sshd
--- a/etc/rc.d/sshd     Sun Oct 19 16:31:47 2014 +0000
+++ b/etc/rc.d/sshd     Sun Oct 19 16:33:01 2014 +0000
@@ -1,6 +1,6 @@
 #!/bin/sh
 #
-# $NetBSD: sshd,v 1.22 2013/02/07 19:32:19 christos Exp $
+# $NetBSD: sshd,v 1.23 2014/10/19 16:33:01 christos Exp $
 #
 
 # PROVIDE: sshd
@@ -17,44 +17,31 @@
 
 sshd_keygen()
 {
-       (
+(
+       keygen="/usr/bin/ssh-keygen"
        umask 022
-       if [ -f /etc/ssh/ssh_host_key ]; then
-               echo "You already have an RSA host key" \
-                   "in /etc/ssh/ssh_host_key"
-               echo "Skipping protocol version 1 RSA Key Generation"
-       else
-               /usr/bin/ssh-keygen -t rsa1 ${ssh_keygen_flags} \
-                   -f /etc/ssh/ssh_host_key -N ''
-       fi
-
-       if [ -f /etc/ssh/ssh_host_dsa_key ]; then
-               echo "You already have a DSA host key" \
-                   "in /etc/ssh/ssh_host_dsa_key"
-               echo "Skipping protocol version 2 DSA Key Generation"
-       else
-               /usr/bin/ssh-keygen -t dsa -b 1024 \
-                   -f /etc/ssh/ssh_host_dsa_key -N ''
-       fi
-
-       if [ -f /etc/ssh/ssh_host_ecdsa_key ]; then
-               echo "You already have a ECDSA host key" \
-                   "in /etc/ssh/ssh_host_ecdsa_key"
-               echo "Skipping protocol version 1 ECDSA Key Generation"
-       else
-               /usr/bin/ssh-keygen -t ecdsa -b 521 \
-                   -f /etc/ssh/ssh_host_ecdsa_key -N ''
-       fi
-
-       if [ -f /etc/ssh/ssh_host_rsa_key ]; then
-               echo "You already have a RSA host key" \
-                   "in /etc/ssh/ssh_host_rsa_key"
-               echo "Skipping protocol version 2 RSA Key Generation"
-       else
-               /usr/bin/ssh-keygen -t rsa ${ssh_keygen_flags} \
-                   -f /etc/ssh/ssh_host_rsa_key -N ''
-       fi
-       )
+       while read type bits filename version name;  do
+               f="/etc/ssh/$filename"
+               if [ -f "$f" ]; then
+                       echo "You already have an $name host key in $f"
+                       echo "Skipping protocol version $version $name" \
+                           "Key Generation"
+               else
+                       case "${bits}" in
+                       -1)     bitarg=;;
+                       0)      bitarg="${ssh_keygen_flags}";;
+                       *)      bitarg="-b ${bits}";;
+                       esac
+                       "${keygen}" -t "${type}" ${bitarg} -f "${f}" -N ''
+               fi
+       done << _EOF
+rsa1   0       ssh_host_key            1       RSA
+dsa    1024    ssh_host_dsa_key        2       DSA
+ecdsa  521     ssh_host_ecdsa_key      1       ECDSA
+ed25519        -1      ssh_host_ed25519_key    1       ED25519
+rsa    0       ssh_host_rsa_key        2       RSA
+_EOF
+)
 }
 
 sshd_precmd()
@@ -62,6 +49,7 @@
        if [ ! -f /etc/ssh/ssh_host_key -o \
            ! -f /etc/ssh/ssh_host_dsa_key -o \
            ! -f /etc/ssh/ssh_host_ecdsa_key -o \
+           ! -f /etc/ssh/ssh_host_ed25519_key -o \
            ! -f /etc/ssh/ssh_host_rsa_key ]; then
                run_rc_command keygen
        fi