[src/trunk]: src/sys/arch/xen Properly implemement pci_intr_disestablish(9), ...

[bouyer <bouyer%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/71b865aae509
branches:  trunk
changeset: 336727:71b865aae509
user:      bouyer <bouyer%NetBSD.org@localhost>
date:      Sat Mar 14 10:49:36 2015 +0000

description:
Properly implemement pci_intr_disestablish(9), so that interrupt
handlers stop being called when the device has been detached.
Should fix PR port-xen/47720 (which turns out to not be related to raidframe).
While there fix possible races in event_remove_handler() and pirq_establish().

diffstat:

 sys/arch/xen/include/evtchn.h       |   3 ++-
 sys/arch/xen/xen/evtchn.c           |  27 +++++++++++++++++++--------
 sys/arch/xen/xen/pci_intr_machdep.c |   5 +++--
 3 files changed, 24 insertions(+), 11 deletions(-)

diffs (114 lines):

diff -r a91795dec174 -r 71b865aae509 sys/arch/xen/include/evtchn.h
--- a/sys/arch/xen/include/evtchn.h     Sat Mar 14 09:52:49 2015 +0000
+++ b/sys/arch/xen/include/evtchn.h     Sat Mar 14 10:49:36 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: evtchn.h,v 1.22 2013/01/12 17:39:46 bouyer Exp $       */
+/*     $NetBSD: evtchn.h,v 1.23 2015/03/14 10:49:36 bouyer Exp $       */
 
 /*
  *
@@ -67,5 +67,6 @@
 
 struct pintrhand *pirq_establish(int, int, int (*)(void *), void *, int,
      const char *);
+void pirq_disestablish(struct pintrhand *);
 
 #endif /*  _XEN_EVENTS_H_ */
diff -r a91795dec174 -r 71b865aae509 sys/arch/xen/xen/evtchn.c
--- a/sys/arch/xen/xen/evtchn.c Sat Mar 14 09:52:49 2015 +0000
+++ b/sys/arch/xen/xen/evtchn.c Sat Mar 14 10:49:36 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: evtchn.c,v 1.70 2013/12/03 20:51:00 bouyer Exp $       */
+/*     $NetBSD: evtchn.c,v 1.71 2015/03/14 10:49:36 bouyer Exp $       */
 
 /*
  * Copyright (c) 2006 Manuel Bouyer.
@@ -54,7 +54,7 @@
 
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: evtchn.c,v 1.70 2013/12/03 20:51:00 bouyer Exp $");
+__KERNEL_RCSID(0, "$NetBSD: evtchn.c,v 1.71 2015/03/14 10:49:36 bouyer Exp $");
 
 #include "opt_xen.h"
 #include "isa.h"
@@ -550,16 +550,16 @@
                return NULL;
        }
 
+       ih->pirq = pirq;
+       ih->evtch = evtch;
+       ih->func = func;
+       ih->arg = arg;
+
        if (event_set_handler(evtch, pirq_interrupt, ih, level, evname) != 0) {
                kmem_free(ih, sizeof(struct pintrhand));
                return NULL;
        }
 
-       ih->pirq = pirq;
-       ih->evtch = evtch;
-       ih->func = func;
-       ih->arg = arg;
-
        physdev_op.cmd = PHYSDEVOP_IRQ_STATUS_QUERY;
        physdev_op.u.irq_status_query.irq = pirq;
        if (HYPERVISOR_physdev_op(&physdev_op) < 0)
@@ -575,6 +575,17 @@
        return ih;
 }
 
+void
+pirq_disestablish(struct pintrhand *ih)
+{
+       int error = event_remove_handler(ih->evtch, pirq_interrupt, ih);
+       if (error) {
+               printf("pirq_disestablish(%p): %d\n", ih, error);
+               return;
+       }
+       kmem_free(ih, sizeof(struct pintrhand));
+}
+
 int
 pirq_interrupt(void *arg)
 {
@@ -772,7 +783,6 @@
        }
        ci = ih->ih_cpu;
        *ihp = ih->ih_evt_next;
-       mutex_spin_exit(&evtlock[evtch]);
 
        ipls = ci->ci_isources[ih->ih_level];
        for (ihp = &ipls->ipl_handlers, ih = ipls->ipl_handlers;
@@ -784,6 +794,7 @@
        if (ih == NULL)
                panic("event_remove_handler");
        *ihp = ih->ih_ipl_next;
+       mutex_spin_exit(&evtlock[evtch]);
        kmem_free(ih, sizeof (struct intrhand));
        if (evts->ev_handlers == NULL) {
                xen_atomic_clear_bit(&ci->ci_evtmask[0], evtch);
diff -r a91795dec174 -r 71b865aae509 sys/arch/xen/xen/pci_intr_machdep.c
--- a/sys/arch/xen/xen/pci_intr_machdep.c       Sat Mar 14 09:52:49 2015 +0000
+++ b/sys/arch/xen/xen/pci_intr_machdep.c       Sat Mar 14 10:49:36 2015 +0000
@@ -1,4 +1,4 @@
-/*      $NetBSD: pci_intr_machdep.c,v 1.16 2014/03/29 19:28:30 christos Exp $      */
+/*      $NetBSD: pci_intr_machdep.c,v 1.17 2015/03/14 10:49:36 bouyer Exp $      */
 
 /*
  * Copyright (c) 2005 Manuel Bouyer.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: pci_intr_machdep.c,v 1.16 2014/03/29 19:28:30 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pci_intr_machdep.c,v 1.17 2015/03/14 10:49:36 bouyer Exp $");
 
 #include <sys/types.h>
 #include <sys/param.h>
@@ -221,4 +221,5 @@
 void
 pci_intr_disestablish(pci_chipset_tag_t pcitag, void *cookie)
 {
+       pirq_disestablish(cookie);
 }