[src/trunk]: src/sys/arch/x86/x86 fix broken error handling; error was used u...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/66655bb323a6
branches:  trunk
changeset: 341186:66655bb323a6
user:      christos <christos%NetBSD.org@localhost>
date:      Fri Oct 23 18:53:26 2015 +0000

description:
fix broken error handling; error was used uninitialized. Changing the
compilation flags broke all threaded programs for me.
XXX: pullup-7

diffstat:

 sys/arch/x86/x86/sys_machdep.c |  13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)

diffs (55 lines):

diff -r 3b3069571e58 -r 66655bb323a6 sys/arch/x86/x86/sys_machdep.c
--- a/sys/arch/x86/x86/sys_machdep.c    Fri Oct 23 18:09:42 2015 +0000
+++ b/sys/arch/x86/x86/sys_machdep.c    Fri Oct 23 18:53:26 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: sys_machdep.c,v 1.28 2014/06/28 21:13:12 dholland Exp $        */
+/*     $NetBSD: sys_machdep.c,v 1.29 2015/10/23 18:53:26 christos Exp $        */
 
 /*-
  * Copyright (c) 1998, 2007, 2009 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: sys_machdep.c,v 1.28 2014/06/28 21:13:12 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: sys_machdep.c,v 1.29 2015/10/23 18:53:26 christos Exp $");
 
 #include "opt_mtrr.h"
 #include "opt_perfctrs.h"
@@ -659,7 +659,6 @@
 #else
        struct pcb *pcb;
        vaddr_t base;
-       int error;
 
        if (l->l_proc->p_flag & PK_32) {
                return x86_set_sdbase32(arg, which, l, direct);
@@ -668,7 +667,7 @@
        if (direct) {
                base = (vaddr_t)arg;
        } else {
-               error = copyin(arg, &base, sizeof(base));
+               int error = copyin(arg, &base, sizeof(base));
                if (error != 0)
                        return error;
        }
@@ -676,10 +675,6 @@
        if (base >= VM_MAXUSER_ADDRESS)
                return EINVAL;
 
-       if (error) {
-               return error;
-       }
-
        pcb = lwp_getpcb(l);
 
        kpreempt_disable();
@@ -699,7 +694,7 @@
        }
        kpreempt_enable();
 
-       return error;
+       return 0;
 #endif
 }